fishy commented on a change in pull request #2431:
URL: https://github.com/apache/thrift/pull/2431#discussion_r682762182
##########
File path: test/go/genmock.sh
##########
@@ -4,7 +4,6 @@ set -e
export GOPATH=$(mktemp -d -t gopath-XXXXXXXXXX)
-# TODO: Once we dropped support to go 1.15, add "@v1.5.0" suffix to go install
Review comment:
NOTE: I removed this TODO because I realized that without "@v1.5.0", `go
install` will actually pick the version according to `go.mod`, which is better
because we don't need to keep the two versions in sync.
##########
File path: test/go/genmock.sh
##########
@@ -4,7 +4,6 @@ set -e
export GOPATH=$(mktemp -d -t gopath-XXXXXXXXXX)
-# TODO: Once we dropped support to go 1.15, add "@v1.5.0" suffix to go install
Review comment:
NOTE: I removed this TODO because I realized that without "@v1.5.0", `go
install` will actually pick the version according to `go.mod`, which is better
because we won't need to keep the two versions in sync.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
