emmenlau commented on pull request #2401:
URL: https://github.com/apache/thrift/pull/2401#issuecomment-894140312


   Dear @aaronmjones,
   our CI was silently not running the tests previously, so your Windows test 
was never executed. In a newer PR I have fixed that, but it seems that this 
breaks your test. Could you kindly take a look at 
https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/40271635/job/3dser86k51a8eco2?fullLog=true
 where it says
   ```
   Test command: C:\projects\build\MSVC2015\x86\bin\Debug\UnitTests.exe
   Test timeout computed to be: 300
   Running 57 test cases...
   unknown location(0): fatal error: in 
"ToStringTest/locale_en_US_int_to_string": 
f:\dd\vctools\crt\crtw32\stdcpp\xmbtowc.c(89) : Assertion failed: 
ploc->_Mbcurmax == 1 || ploc->_Mbcurmax == 2
   
   C:\projects\thrift\lib\cpp\test\ToStringTest.cpp(44): last checkpoint: 
"locale_en_US_int_to_string" entry.
   unknown location(0): fatal error: in 
"ToStringTest/locale_de_DE_floating_point_to_string": 
f:\dd\vctools\crt\crtw32\stdcpp\xmbtowc.c(89) : Assertion failed: 
ploc->_Mbcurmax == 1 || ploc->_Mbcurmax == 2
   
   C:\projects\thrift\lib\cpp\test\ToStringTest.cpp(53): last checkpoint: 
"locale_de_DE_floating_point_to_string" entry.
   An error message from getaddrinfo on the console is expected:
   Thrift: Thu Aug  5 19:53:55 2021 getaddrinfo() -> 11001; No such host is 
known.
   
   
   *** 2 failures are detected in the test module "thrift"
   Test #381: UnitTests ........................***Failed    3.59 sec
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to