aaronmjones commented on pull request #2401: URL: https://github.com/apache/thrift/pull/2401#issuecomment-896141365
That assertion happens in the std::locale() constructor and was also reported at https://developercommunity.visualstudio.com/t/stdlocale-l2-en-usutf-8-broken-crashes-now/330322. That link says it was fixed in VS2019 16.9. Maybe there's a way to avoid the assertion with the version of VS the Windows CI is using (is it VS2015?). But reading the documentation of std::locale(), it can throw: >std::runtime_error if the operating system has no locale named std_name or if std_name is a null pointer. I modified the ubuntu Dockerfiles to install the locales used by the unit tests ("en-US.UTF-8" and de-DE.UTF-8"). I don't know how to do the same on Windows in order to guarantee std::locale() does not throw. How do you feel about enabling those 2 unit tests only on Linux platforms? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
