fishy commented on pull request #2435: URL: https://github.com/apache/thrift/pull/2435#issuecomment-896331260
The test looks good, but I realized that since `NewTSocketConf` can never return an error now, I'd remove that from the function signature while I'm here. Also updated some of the tests to stop using deprecated functions and switch to use the -Conf versions. @dcelasun please take another look :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
