emmenlau commented on pull request #2007: URL: https://github.com/apache/thrift/pull/2007#issuecomment-910204090
Ok @cfried, I'm sorry but there is indeed a problem: With your changes, there are consistent crashes on all Windows builds (MSVC and MINGW) in `processor_test`, see https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/40571399. With another very recent build from yesterday, we do not get these, see https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/40603625. You can try to rebase again on latest master and force push, just to be sure its not a random fluctuation. But if the Windows tests fail again, we will need to follow it up (or at least not merge). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
