fishy commented on a change in pull request #2453:
URL: https://github.com/apache/thrift/pull/2453#discussion_r705749697
##########
File path: compiler/cpp/src/thrift/generate/t_go_generator.cc
##########
@@ -4021,7 +4021,7 @@ string t_go_generator::type_to_go_key_type(t_type* type) {
}
if (resolved_type->is_binary())
- return "string";
+ return "[]byte";
Review comment:
looks good to me, will approve and merge it after the travis run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
