fishy commented on a change in pull request #2455:
URL: https://github.com/apache/thrift/pull/2455#discussion_r711865341
##########
File path: lib/go/thrift/socket_windows_conn.go
##########
@@ -1,4 +1,4 @@
-// +build windows
+// +build windows wasm
Review comment:
yes please.
while you are here, could you please also run `gofmt` from 1.17+ on these 2
files? go 1.17 introduced new build constraint format, and `gofmt` 1.17+ would
auto generate the new build constraint from the old one. (the new one starts
with `//go:build` instead of `// +build`, after running `gofmt` both should be
there).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
