fishy commented on a change in pull request #2468:
URL: https://github.com/apache/thrift/pull/2468#discussion_r730439578
##########
File path: lib/go/thrift/go.mod
##########
@@ -0,0 +1,6 @@
+module github.com/apache/thrift/lib/go/thrift
+
+go 1.17
+
+// Accidentally pushed version with lib/go/thrift/go.mod, please update using
`go get github.com/apache/thrift@latest`.
Review comment:
@dcelasun I think the whole UI design around retract message display is
for one-liners, I think it should be kept as short as possible and I'm not sure
if two lines will break things. See
https://pkg.go.dev/github.com/fishy/test-go-mod-retract/[email protected] and
```
$ go get github.com/fishy/test-go-mod-retract/[email protected]
go: downloading github.com/fishy/test-go-mod-retract/lib v0.0.1-retract
go: warning: github.com/fishy/test-go-mod-retract/[email protected]:
retracted by module author: Have go.mod on non-root, never meant to happen.
go: to switch to the latest unretracted version, run:
go get github.com/fishy/test-go-mod-retract/lib@latest
go get: added github.com/fishy/test-go-mod-retract/lib v0.0.1-retract
```
for examples.
But maybe we should just link to the git tag on github
(https://github.com/apache/thrift/releases/tag/lib/go/thrift/v0.0.1-do-not-use,
which does not exist yet but will be once we tagged it), and we can write more
detailed messages (with links to both the go issue and THRIFT-5472) there. what
do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
