Jens-G commented on a change in pull request #2474:
URL: https://github.com/apache/thrift/pull/2474#discussion_r738828325



##########
File path: lib/java/src/org/apache/thrift/protocol/TSimpleJSONProtocol.java
##########
@@ -314,6 +314,7 @@ public void writeString(String str) throws TException {
       char c = str.charAt(i);
       switch (c) {
       case '"':
+        escape.append('\\');
       case '\\':

Review comment:
       So this is the whole net patch content, buried under a pile of unrelated 
other changes. 
   Plus I don't think this change is even remotely correct




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to