wujjpp commented on a change in pull request #2407:
URL: https://github.com/apache/thrift/pull/2407#discussion_r760940616
##########
File path: lib/nodejs/lib/thrift/connection.js
##########
@@ -198,6 +200,16 @@ Connection.prototype.connection_gone = function () {
var self = this;
this.connected = false;
+ // If closed by manual, emit close event and cancel reconnect process
+ if(this.forceClose) {
+ self.emit("close");
Review comment:
>
Correct, `close callback` maybe cause pedantic.
I have updated this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
