fishy commented on pull request #2487:
URL: https://github.com/apache/thrift/pull/2487#issuecomment-995502244


   > Unfortunately the error couldn't be reproduced on CI since the python 
version (3.6.9) doesn't actually contain the warning. Regardless, I think 
having warnings as errors should be beneficial - especially once the CI pythons 
are updated.
   
   In that case, I'd prefer to revert the CI changes. I don't want the CI to 
start fail suddenly when Ubuntu decided to upgrade python3 in their version 
from 3.6 to 3.7.
   
   We _might_ want to consider the CI change in a separated PR so it can be 
reverted, but that still sounds quite risky to me, as when that upgrade in 
ubuntu actually happens no one would remember this is the commit to be reverted.
   
   Sorry about the back-and-forth.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to