fishy commented on a change in pull request #2497:
URL: https://github.com/apache/thrift/pull/2497#discussion_r780701343
##########
File path: lib/go/thrift/simple_server.go
##########
@@ -54,10 +55,10 @@ var ServerConnectivityCheckInterval = time.Millisecond * 5
* This will work if golang user implements a conn-pool like thing in client
side.
*/
type TSimpleServer struct {
- closed int32
- wg sync.WaitGroup
- mu sync.Mutex
-
+ closed int32
+ wg sync.WaitGroup
+ mu sync.Mutex
+ stopChan chan struct{}
Review comment:
nit: I would still prefer to have a blank line after this line so we
have the logical "groups" of the fields of a `TSimpleServer`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
