fishy edited a comment on pull request #2497:
URL: https://github.com/apache/thrift/pull/2497#issuecomment-1008343546
hmm, this test failed on travis:
```
Making check in go
make[2]: Entering directory '/thrift/src/test/go'
Makefile:657: warning: overriding recipe for target 'check'
Makefile:506: warning: ignoring old recipe for target 'check'
grep -v list.*map.*list.*map ../../test/ThriftTest.thrift > ThriftTest.thrift
mkdir -p src/gen
/thrift/src/compiler/cpp/thrift -out src/gen --gen
go:thrift_import=github.com/apache/thrift/lib/go/thrift,package_prefix=github.com/apache/thrift/test/go/src/gen/
ThriftTest.thrift
[WARNING:/thrift/src/test/go/ThriftTest.thrift:43] No generator named
'noexist' could be found!
[WARNING:/thrift/src/test/go/ThriftTest.thrift:45] cpp generator does not
accept 'noexist' as sub-namespace!
/thrift/src/compiler/cpp/thrift -out src/gen --gen
go:thrift_import=github.com/apache/thrift/lib/go/thrift,package_prefix=github.com/apache/thrift/test/go/src/gen/
../StressTest.thrift
[WARNING:/thrift/src/test/StressTest.thrift:31] Consider using the more
efficient "binary" type instead of "list<byte>".
[WARNING:/thrift/src/test/StressTest.thrift:31] Consider using the more
efficient "binary" type instead of "list<byte>".
touch gopath
sh genmock.sh
go: downloading github.com/golang/mock v1.5.0
go: downloading golang.org/x/mod v0.3.0
go: downloading golang.org/x/tools v0.0.0-20191119224855-298f0cb1881e
go: downloading golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898
/usr/local/bin/go test -mod=mod -v ./src/common/...
=== RUN TestAllConnection
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x6cc5da]
goroutine 9 [running]:
github.com/apache/thrift/lib/go/thrift.(*TSimpleServer).innerAccept.func1()
/thrift/src/lib/go/thrift/simple_server.go:205 +0xba
created by
github.com/apache/thrift/lib/go/thrift.(*TSimpleServer).innerAccept
/thrift/src/lib/go/thrift/simple_server.go:201 +0x1c8
FAIL github.com/apache/thrift/test/go/src/common 0.015s
FAIL
Makefile:657: recipe for target 'check' failed
make[2]: *** [check] Error 1
make[2]: Leaving directory '/thrift/src/test/go'
```
but I cannot reproduce it locally and it doesn't make sense to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
