buptubuntu commented on pull request #2497:
URL: https://github.com/apache/thrift/pull/2497#issuecomment-1008452186
> Oh I think I know why (~but I wonder why did this not fail before~ it
didn't fail before because we never called `TSimpleServer.logger` in that test
before)
>
> @buptubuntu please apply this diff to the PR:
>
> ```diff
> diff --git a/test/go/src/common/clientserver_test.go
b/test/go/src/common/clientserver_test.go
> index 609086bad..64b326a81 100644
> --- a/test/go/src/common/clientserver_test.go
> +++ b/test/go/src/common/clientserver_test.go
> @@ -75,7 +75,7 @@ func doUnit(t *testing.T, unit *test_unit) {
> t.Errorf("Unable to start server: %v", err)
> return
> }
> - go server.AcceptLoop()
> + go server.Serve()
> defer server.Stop()
> client, trans, err := StartClient(unit.host, unit.port,
unit.domain_socket, unit.transport, unit.protocol, unit.ssl)
> if err != nil {
> ```
ok，later today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
