buptubuntu edited a comment on pull request #2497:
URL: https://github.com/apache/thrift/pull/2497#issuecomment-1011220542


   > I don't know what's the best way to fix that. Maybe add a setting to 
`TSimpleServer` to sleep for a period of time before trying to abruptly close 
all connections is a ok short term solution. for long term we might need to 
make some breaking changes to `TProtocol`/`TTransport` to add the graceful 
shutdown semantic to them.
   
   the key is to prevent the server to hang for too long or hang for 
ever,because that will block in some pipeline inside a process.As the listener 
is closed, new client can not connect to ther server(imaging a standalone 
application), if hang for too long to wait for the server to shutdown and 
restart, it maybe worse
   
   i think the former is a better choice


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to