buptubuntu commented on a change in pull request #2497: URL: https://github.com/apache/thrift/pull/2497#discussion_r793210474
########## File path: lib/go/README.md ########## @@ -132,3 +132,28 @@ if this interval is set to a value too low (for example, 1ms), it might cause excessive cpu overhead. This feature is also only enabled on non-oneway endpoints. + +A note about server stop implementations +======================================== + +[TSimpleServer.Stop](https://pkg.go.dev/github.com/apache/thrift/lib/go/thrift#TSimpleServer.Stop) will wait for all client connections to be closed after +the last received or to be received request to be hanled, so the time spent by stop Review comment: Emmm, current head will check `closed` after `processor.Process` finish receiving and handling a request in `TSimpleServer.processRequests`, if `closed` is set to 1, `inputTransport.Close()` and `outputTransport.Close()` will close the client, so i use the term `last received or to be received request` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
