dcelasun commented on a change in pull request #2514:
URL: https://github.com/apache/thrift/pull/2514#discussion_r798885625



##########
File path: lib/go/thrift/socket_conn.go
##########
@@ -83,7 +84,17 @@ func (sc *socketConn) IsOpen() bool {
        if !sc.isValid() {
                return false
        }
-       return sc.checkConn() == nil
+       if err := sc.checkConn(); err != nil {
+               if !errors.Is(err, net.ErrClosed) {
+                       // The connectivity check failed and the error is not
+                       // that the conncetion is already closed, we need to

Review comment:
       ```suggestion
                        // that the connection is already closed, we need to
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to