ferrirW edited a comment on pull request #2533: URL: https://github.com/apache/thrift/pull/2533#issuecomment-1053882220
> For the sake of consistency, we should aim to use > DEFAULT_RECURSION_LIMIT = 64; > DEFAULT_MAX_MESSAGE_SIZE = 100 * 1024 * 1024; // 100 MB > DEFAULT_MAX_FRAME_SIZE = 16384000; // this value is used consistently across all Thrift libraries Is it a good idea to use TConfiguration maxFrameSize？ 1. static final constant DEFAULT_MAX_FRAME_SIZE is not able for customization. 2. so i have to use trans_.getConfiguration().getMaxFrameSize(), but that means many class need to be modified(TNonblockingSocket, TNonblockingServerSocket, AbstractServerTransportArgs, NonblockingAbstractServerSocketArgs and TEndpointTransport) 3. and if i want use it in 0.9.1, i must add TConfiguration-related code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
