kainjow commented on a change in pull request #2523:
URL: https://github.com/apache/thrift/pull/2523#discussion_r825244260
##########
File path: compiler/cpp/src/thrift/generate/t_py_generator.cc
##########
@@ -127,6 +128,9 @@ class t_py_generator : public t_generator {
gen_tornado_ = true;
} else if( iter->first.compare("coding") == 0) {
coding_ = iter->second;
+ } else if( iter->first.compare("type_hints") == 0) {
+ gen_type_hints_ = true;
+ gen_enum_ = true;
Review comment:
should the help text below mention that the enum option is also enabled
if this option is enabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
