Jimexist commented on pull request #2529:
URL: https://github.com/apache/thrift/pull/2529#issuecomment-1066277966


   > Ok thanks but I also mean w/regard to @ctubbsii 's comments.
   
   I think our use cases might differ.
   
   Currently the setup (in this pull request) is to have four possible values 
for the option argument:
   1. Nullable getters if argument is absent
   1. Thrift option returning getters  if argument is present and the default 
case is this (back compatible)
   1. JDK option returning getters if argument is present with jdk8 value
   1. Both 1 and 3 except option returning getters will be defined with 
Optional postfix
   
   
   I would argument 4 is needed because in my use case both Java code and 
kotlin code will be consumers and Java needs option returning getters to do 
proper option chaining while having null returning getters makes kotlin 
recognize the property as is and it does option chaining from there.
   
   In all of the cases they are additive and users can choose from the behavior 
so I guess it'll be needed and useful.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to