jeffalder commented on pull request #2511: URL: https://github.com/apache/thrift/pull/2511#issuecomment-1069989222
I see how homebrew is building bottles. The [homebrew recipe](https://github.com/Homebrew/homebrew-core/blob/master/Formula/thrift.rb#L69) includes [ENV.deparallelize](https://rubydoc.brew.sh/Superenv.html#deparallelize-instance_method), which removes the MAKEFLAGS environment variable. In my build log, I see this: ``` clang++ called with: -std=c++11 -DHAVE_CONFIG_H -I./src -Wall -Wextra -pedantic -Werror -g -O2 -MT src/thrift/generate/thrift-t_netstd_generator.o -MD -MP -MF src/thrift/generate/.deps/thrift-t_netstd_generator.Tpo -c -o src/thrift/generate/thrift-t_netstd_generator.o src/thrift/generate/t_netstd_generator.cc superenv removed: -Wall -Wextra -pedantic -Werror -g -O2 superenv added: -pipe -w -Os -stdlib=libc++ -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk --sysroot=/Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk -isystem/opt/homebrew/include -isystem/Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk/System/Library/Frameworks/OpenGL.framework/Versions/Current/Headers -I/opt/homebrew/opt/[email protected]/include superenv executed: clang++ -pipe -w -Os -std=c++11 -stdlib=libc++ -std=c++11 -DHAVE_CONFIG_H -I./src -MT src/thrift/generate/thrift-t_netstd_generator.o -MD -MP -MF src/thrift/generate/.deps/thrift-t_netstd_generator.Tpo -c -o src/thrift/generate/thrift-t_netstd_generator.o src/thrift/generate/t_netstd_generator.cc -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk --sysroot=/Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk -isystem/opt/homebrew/include -isystem/Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk/System/Library/Frameworks/OpenGL.framework/Versions/Current/Headers -I/opt/homebrew/opt/[email protected]/include ``` So `ENV.deparallelize` is removing the `-Wall -Wextra -pedantic -Werror` settings, which means that the command-line flag that triggered that error has been removed for homebrew builds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
