ctubbsii commented on PR #2559: URL: https://github.com/apache/thrift/pull/2559#issuecomment-1095922213
I just learned about clang-format. It seems nice... but a quick check shows it's defaults would change a lot of thrift code, and not always for the better. I'm not sure if the Thrift community would endorse its use, but there is a .clang-format file in the root directory. It seems it hasn't been run in awhile. It might be easier to just look over this PR and try to undo the formatting changes. Or, just rely on reviewers to figure it out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
