Jimexist commented on code in PR #2559:
URL: https://github.com/apache/thrift/pull/2559#discussion_r847965868
##########
compiler/cpp/src/thrift/generate/t_java_generator.cc:
##########
@@ -468,6 +469,10 @@ string t_java_generator::java_nullable_annotation() {
return "@org.apache.thrift.annotation.Nullable";
}
+string t_java_generator::java_override_annotation() {
+ return "@java.lang.Override";
Review Comment:
> it's done elsewhere (for String)
using fully qualified names (even for `java.lang.*`) allows for structs to
be named `String` (although it's not a good practice) and used in the same
package - otherwise it won't compile (some of the tests in `test/` folder does
this).
For annotations i think it's fine to not to use fully qualified name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
