ctubbsii commented on code in PR #2559:
URL: https://github.com/apache/thrift/pull/2559#discussion_r847988794
##########
compiler/cpp/src/thrift/generate/t_java_generator.cc:
##########
@@ -2108,8 +2117,8 @@ void
t_java_generator::generate_java_struct_compare_to(ostream& out, t_struct* t
*
* @param tstruct The struct definition
*/
-void t_java_generator::generate_java_struct_reader(ostream& out, t_struct*
tstruct) {
- (void)tstruct;
+void t_java_generator::generate_java_struct_reader(ostream& out, t_struct*
/*tstruct*/) {
Review Comment:
That's fine... I just didn't know you could comment out the variable name,
but leave the type in place. You definitely can't do that in Java, but it does
make sense... you're keeping the same signature just not using the variable.
:smiley_cat:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
