Jimexist commented on PR #2525: URL: https://github.com/apache/thrift/pull/2525#issuecomment-1100583315
@Jens-G and @ctubbsii thank you _both_ for all your time and efforts invested into reviewing my code last few weeks, I truly appreciate that. As PMC (or any other PMC can chime in as well), do you think you can shed some light on how to better contribute here (both as a committer like @ctubbsii or non-committers like me). I can't find it neither in https://thrift.apache.org/about or some other links, but it maybe was just me. Some examples where I don't know if I should go ahead and make changes: 1. there are JUnit 3 and 4 style unit tests in Java repo, but the mainstream version is now JUnit 5 2. some cross tests drivers in Java lib is not out of date and can't run with the python driver now - not sure if they should be removed I know that it's non-trivial for projects like Thrift given its multi-language and not all members are familiar with all languages - but given I don't see a lot of reviews on Java side of the code lately I wonder if there's any mechanism to make sure enough coverage / attention / review there is for major languages. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
