Jens-G commented on PR #2525: URL: https://github.com/apache/thrift/pull/2525#issuecomment-1100597451
> there are JUnit 3 and 4 style unit tests in Java repo, but the mainstream version is now JUnit 5 Usually if something is going to get outdated it's a good decision to stop using the old stuff, simply to reduce maintenance burden. It's however always also a case-by-case decision. It depends. Whatever makes most sense. Especially as it is "only" about tests I probably would drop 3 and 4 altogether and only use 5, but please take that personal opinion with a grain of salt. > some cross tests drivers in Java lib is not out of date [...] Any way to get that fixed? > given I don't see a lot of reviews on Java side of the code lately I wonder if there's any > mechanism to make sure enough coverage / attention / review there is for major languages. Yes, that's a constant fight. Some areas are covered by reviewers more than others. I also wonder a bit ... Java is a mainstream language, but we have less activity as say Go and Rust lately. On the other hand, you hardly can't people force to do voluntary work. > you can shed some light on how to better contribute here Well. pretty simple actually. First, we have http://thrift.apache.org/docs/HowToContribute which covers the contribution part. Patches and PRs are reviewed by committers either because someone picks it himself or gets asked and then does it. If all sides are happy, it gets merged and the JIRA ticket updated. Only breaking changes should be documented in CHANGES.md, all else in that document will be filled up when we do a release. Of course anyone else is also welcome to review stuff. Given enough eyes all bugs are shallow, as the saying goes. For each committer, it is hard to say if a change beyond a certain level of complexity is good or bad if it is in some subsystem he/she does not understand. One usually leaves these tickets to people more skilled in that area. You might have some luck if you do a post to the dev list asking about a reviewer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
