Jimexist commented on PR #2556: URL: https://github.com/apache/thrift/pull/2556#issuecomment-1100783377
> > > Also, I'm, not sure about that JAR file being added to the source tree. > > > > > > Did you mean the gradle wrapper jar? It is expected to be checked in in order to have consistent build, per gradle doc: https://docs.gradle.org/current/userguide/gradle_wrapper.html > > > To make the Wrapper files available to other developers and execution environments you’ll need to check them into version control. All Wrapper files including the JAR file are very small in size. Adding the JAR file to version control is expected. > > > > > > Also I think it is the same situation for lib/java > > This has been discussed at length in other forums. I understand why people like using the gradle wrapper... but the jar shouldn't be in the source tree. If that means no gradle wrapper, then so be it. I understand people feel strongly about this, and want to argue in favor of it, but it can't be there. The one in lib/java should be removed. ok in that case i'll just symbolically link to the java one so they are identical. there's a way to verify the wrapper jar using sha256sum, i can maybe modify `FindGradlew.cmake` in another pull request to make it more secure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
