ctubbsii commented on PR #2556: URL: https://github.com/apache/thrift/pull/2556#issuecomment-1100919488
> > The one in lib/java should be removed. > > @ctubbsii removing that requires significant rework on the build script, i'll probably find another time to do it? It's probably okay as long as the source tarball that is voted on and released doesn't include it. To remove it from git, the easiest thing to do is probably to just have the bootstrap.sh script download it. But, most of the places can probably just call gradle directly and leave it to the user to get the specified version. In any case, it doesn't need to be done as part of this PR, but it probably should be done before the next release. I'm not a PMC member, and releases are ultimately a PMC responsibility. I'd help but I don't really know Gradle very well, as I mostly use Maven. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
