Jimexist commented on code in PR #2574:
URL: https://github.com/apache/thrift/pull/2574#discussion_r851924190
##########
lib/java/test/org/apache/thrift/test/EqualityTest.java:
##########
@@ -129,10 +129,11 @@ public static void main(String[] args) throws Exception {
package org.apache.thrift.test;
// Generated code
-import java.nio.ByteBuffer;
import thrift.test.JavaTestHelper;
+import java.nio.ByteBuffer;
Review Comment:
this is reverted
##########
lib/java/test/org/apache/thrift/async/TestTAsyncClient.java:
##########
@@ -1,13 +1,16 @@
package org.apache.thrift.async;
-import junit.framework.TestCase;
import org.apache.thrift.TException;
-
+import org.junit.jupiter.api.Test;
import thrift.test.Srv;
import thrift.test.Srv.AsyncClient;
-public class TestTAsyncClient extends TestCase {
+import static org.junit.jupiter.api.Assertions.fail;
Review Comment:
this is fixed now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
