ctubbsii commented on code in PR #2553:
URL: https://github.com/apache/thrift/pull/2553#discussion_r854113692
##########
compiler/cpp/src/thrift/generate/t_java_generator.cc:
##########
@@ -5737,4 +5774,6 @@ THRIFT_REGISTER_GENERATOR(
" generated_annotations=[undated|suppress]:\n"
" undated: suppress the date at @Generated
annotations\n"
" suppress: suppress @Generated annotations entirely\n"
- " unsafe_binaries: Do not copy ByteBuffers in constructors, getters,
and setters.\n")
+ " unsafe_binaries: Do not copy ByteBuffers in constructors, getters,
and setters.\n"
+ " annotations_as_metadata:\n"
+ " Include annotations as metadata in the generated
code.\n")
Review Comment:
Just a tiny bit more clarification here would help I think.
```suggestion
" Include Thrift field annotations as metadata in
the generated code.\n")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]