Jimexist commented on PR #2592:
URL: https://github.com/apache/thrift/pull/2592#issuecomment-1111859568

   > > > cc @Jens-G i guess this needs to be enabled _after_ the merge - for 
now i can't see from the actions tab whether it's working or not
   > > 
   > > 
   > > You should be able to see if it's working in your fork.
   > 
   > thanks for the pointer - it's 
https://github.com/Jimexist/thrift/actions/runs/2237581561 and working for now
   
   with that passed i plan to leave this pull request as is and put future work 
in subsequent pull requests to make the change / shift incremental.
   
   my current plan is to have several steps:
   1. enable thrift compiler building in ubuntu (this PR)
   2. enable thrift compiler building in macOS and windows
   3. use [artifact sharing][1] to share the pre-built compiler, and create 
subsequent library building workflows per language - this is unlike the current 
setup in travis where a monolithic docker environment has to be setup
   4. if that goes smoothly, have a final cross test runner that combines all 
the built cross test runners 
   
   
   [1]: 
https://docs.github.com/en/actions/using-workflows/storing-workflow-data-as-artifacts


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to