ctubbsii commented on PR #2593:
URL: https://github.com/apache/thrift/pull/2593#issuecomment-1112492713

   I'm noticing the job name is quite long, which makes it hard to see the 
matrix params in the PR display. You can probably shorten it from "Build Thrift 
Compiler and Libraries" to just "Build" or similar.
   
   You can also reduce the number of items in the matrix, and the output, by 
not making the Java distribution a matrix. It's probably sufficient to just use 
a single stable Java distribution. If temurin works, then just use that, but 
don't need to put it in the matrix.
   
   You can also probably remove the Java 8 builds, since Java 11 should be 
using `--release 8` when it builds anyway, if the intent is to support Java 8. 
It'd be more useful to include Java 17 (which is the current LTS), and Java 11 
(former LTS, still popular).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to