ctubbsii commented on PR #2581: URL: https://github.com/apache/thrift/pull/2581#issuecomment-1116068062
> > After the rebase (and reformat) this seems fixed now. @ctubbsii you can verify by `git checkout master -- lib/java/src/main` and then run again `gradle spotlessApply` to see that all code changes are indeed auto-format. > > well actually that was a lie - for only one of the file i indeed need to remove the wildcard import as to remove ambiguity of `String` generated by thrift and `java.lang.String` If the check is fast enough, could add a task to format during CI, and fail the CI check if it results in any changes to tracked files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
