ctubbsii commented on PR #2574:
URL: https://github.com/apache/thrift/pull/2574#issuecomment-1118981476

   > hi @ctubbsii do you still have any questions regarding this pull request? 
if no possibly this can be merged before:
   > 
   > * [THRIFT-5568: use spotless plugin and google-java-format to enforce a 
consistent code formatĀ #2581](https://github.com/apache/thrift/pull/2581)
   > 
   > because otherwise it'll introduce a lot of hard to resolve conflicts with 
this; on the other hand i can always just re-format if this pull request goes 
in first
   
   @Jimexist I merged this first, because I thought you were saying this PR 
should be merged before that one. But, now I see conflicts in that one. So, I'm 
wondering if you meant that one could be merged first. Apologies if I 
misunderstood. I can merge that one in next once the conflicts are resolved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to