Jimexist commented on code in PR #2600:
URL: https://github.com/apache/thrift/pull/2600#discussion_r867438004
##########
lib/kotlin/cross-test-client/build.gradle.kts:
##########
@@ -31,6 +31,7 @@ repositories {
dependencies {
implementation(platform("org.jetbrains.kotlin:kotlin-bom"))
implementation("org.jetbrains.kotlin:kotlin-stdlib-jdk8")
+ implementation("com.github.ajalt.clikt:clikt:3.4.2")
Review Comment:
@ctubbsii testImplementation is for unit tests, here we are building a test
binary (application) for cross test.
In java it's achieved by configuring a shadowJar with customized source set
`crossTest` but here we use a different approach (i.e. multi module gradle
project). The whole project in Kotlin library is _not_ published, because at
runtime it only uses Java libthrift. Here the content under `lib/kotlin` is
only for driving cross tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
