Jimexist commented on code in PR #2601:
URL: https://github.com/apache/thrift/pull/2601#discussion_r867438354
##########
lib/java/Makefile.am:
##########
@@ -26,7 +26,7 @@ all-local:
--console=plain
install-exec-hook:
- $(GRADLE) $(GRADLE_OPTS) install \
+ $(GRADLE) $(GRADLE_OPTS) publishToMavenLocal \
Review Comment:
i agree with your preference on consistency.
here our hands are tied because `publishToMavenLocal` is provided by the
`maven-publish` plugin:
https://docs.gradle.org/current/userguide/publishing_maven.html#publishing_maven:tasks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
