Jimexist commented on PR #2601:
URL: https://github.com/apache/thrift/pull/2601#issuecomment-1120602254

   FYI i think JDK 8 support is still with Gradle 7:
   
   <details>
   <summary>build log</summary>
   
   ```bash
   root@5ec15a799389:/opt/thrift/src/lib/java# ./gradlew
   bash: ./gradlew: No such file or directory
   root@5ec15a799389:/opt/thrift/src/lib/java# java -version
   openjdk version "1.8.0_332"
   OpenJDK Runtime Environment (build 1.8.0_332-b09)
   OpenJDK 64-Bit Server VM (build 25.332-b09, mixed mode)
   root@5ec15a799389:/opt/thrift/src/lib/java# ./gradlew assemble
   Downloading https://services.gradle.org/distributions/gradle-7.4.2-bin.zip
   
...........10%...........20%...........30%...........40%...........50%...........60%...........70%...........80%...........90%...........100%
   
   Welcome to Gradle 7.4.2!
   
   Here are the highlights of this release:
    - Aggregated test and JaCoCo reports
    - Marking additional test source directories as tests in IntelliJ
    - Support for Adoptium JDKs in Java toolchains
   
   For more details see https://docs.gradle.org/7.4.2/release-notes.html
   
   Starting a Gradle Daemon (subsequent builds will be faster)
   
   > Task :compileJava
   Note: Some input files use unchecked or unsafe operations.
   Note: Recompile with -Xlint:unchecked for details.
   
   > Task :javadoc
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/EnumCache.java:51:
 warning: no @return
     public TEnum get(Class<? extends TEnum> enumClass, int value) {
                  ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/ThriftMetadata.java:112:
 warning: no @param for level
       protected String getIndent(int level) {
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/ThriftMetadata.java:112:
 warning: no @return
       protected String getIndent(int level) {
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/ThriftMetadata.java:117:
 warning: no @param for sb
       protected void append(StringBuilder sb, String format, Object... args) {
                      ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/ThriftMetadata.java:117:
 warning: no @param for format
       protected void append(StringBuilder sb, String format, Object... args) {
                      ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/ThriftMetadata.java:117:
 warning: no @param for args
       protected void append(StringBuilder sb, String format, Object... args) {
                      ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/ThriftMetadata.java:122:
 warning: no @return
       protected String getName() {
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:37:
 warning: no @param for obj
     public static void checkNotNull(Object obj, String argName) {
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:37:
 warning: no @param for argName
     public static void checkNotNull(Object obj, String argName) {
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:42:
 warning: no @param for value
     public static void checkPositiveInteger(long value, String argName) {
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:42:
 warning: no @param for argName
     public static void checkPositiveInteger(long value, String argName) {
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:47:
 warning: no @param for value
     public static void checkNotNegative(long value, String argName) {
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:47:
 warning: no @param for argName
     public static void checkNotNegative(long value, String argName) {
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:59:
 warning: no @param for isValid
     public static void checkValid(boolean isValid, String argName) {
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:59:
 warning: no @param for argName
     public static void checkValid(boolean isValid, String argName) {
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:64:
 warning: no @param for isValid
     public static void checkValid(boolean isValid, String argName, String 
validValues) {
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:64:
 warning: no @param for argName
     public static void checkValid(boolean isValid, String argName, String 
validValues) {
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:64:
 warning: no @param for validValues
     public static void checkValid(boolean isValid, String argName, String 
validValues) {
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:69:
 warning: no @param for arg
     public static void checkNotNullAndNotEmpty(String arg, String argName) {
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:69:
 warning: no @param for argName
     public static void checkNotNullAndNotEmpty(String arg, String argName) {
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:75:
 warning: no @param for <T>
     public static <T> void checkNotNullAndNotEmpty(T[] array, String argName) {
                            ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:75:
 warning: no @param for array
     public static <T> void checkNotNullAndNotEmpty(T[] array, String argName) {
                            ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:75:
 warning: no @param for argName
     public static <T> void checkNotNullAndNotEmpty(T[] array, String argName) {
                            ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:81:
 warning: no @param for array
     public static void checkNotNullAndNotEmpty(byte[] array, String argName) {
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:81:
 warning: no @param for argName
     public static void checkNotNullAndNotEmpty(byte[] array, String argName) {
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:87:
 warning: no @param for array
     public static void checkNotNullAndNotEmpty(short[] array, String argName) {
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:87:
 warning: no @param for argName
     public static void checkNotNullAndNotEmpty(short[] array, String argName) {
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:93:
 warning: no @param for array
     public static void checkNotNullAndNotEmpty(int[] array, String argName) {
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:93:
 warning: no @param for argName
     public static void checkNotNullAndNotEmpty(int[] array, String argName) {
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:99:
 warning: no @param for array
     public static void checkNotNullAndNotEmpty(long[] array, String argName) {
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:99:
 warning: no @param for argName
     public static void checkNotNullAndNotEmpty(long[] array, String argName) {
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:105:
 warning: no @param for <T>
     public static <T> void checkNotNullAndNotEmpty(Iterable<T> iter, String 
argName) {
                            ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:105:
 warning: no @param for iter
     public static <T> void checkNotNullAndNotEmpty(Iterable<T> iter, String 
argName) {
                            ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:105:
 warning: no @param for argName
     public static <T> void checkNotNullAndNotEmpty(Iterable<T> iter, String 
argName) {
                            ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:112:
 warning: no @param for <T>
     public static <T> void checkNotNullAndNumberOfElements(
                            ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:112:
 warning: no @param for collection
     public static <T> void checkNotNullAndNumberOfElements(
                            ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:112:
 warning: no @param for numElements
     public static <T> void checkNotNullAndNumberOfElements(
                            ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:112:
 warning: no @param for argName
     public static <T> void checkNotNullAndNumberOfElements(
                            ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:124:
 warning: no @param for value1
     public static void checkValuesEqual(
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:124:
 warning: no @param for value1Name
     public static void checkValuesEqual(
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:124:
 warning: no @param for value2
     public static void checkValuesEqual(
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:124:
 warning: no @param for value2Name
     public static void checkValuesEqual(
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:136:
 warning: no @param for value1
     public static void checkIntegerMultiple(
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:136:
 warning: no @param for value1Name
     public static void checkIntegerMultiple(
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:136:
 warning: no @param for value2
     public static void checkIntegerMultiple(
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:136:
 warning: no @param for value2Name
     public static void checkIntegerMultiple(
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:148:
 warning: no @param for value1
     public static void checkGreater(long value1, String value1Name, long 
value2, String value2Name) {
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:148:
 warning: no @param for value1Name
     public static void checkGreater(long value1, String value1Name, long 
value2, String value2Name) {
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:148:
 warning: no @param for value2
     public static void checkGreater(long value1, String value1Name, long 
value2, String value2Name) {
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:148:
 warning: no @param for value2Name
     public static void checkGreater(long value1, String value1Name, long 
value2, String value2Name) {
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:159:
 warning: no @param for value1
     public static void checkGreaterOrEqual(
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:159:
 warning: no @param for value1Name
     public static void checkGreaterOrEqual(
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:159:
 warning: no @param for value2
     public static void checkGreaterOrEqual(
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:159:
 warning: no @param for value2Name
     public static void checkGreaterOrEqual(
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:171:
 warning: no @param for value1
     public static void checkLessOrEqual(
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:171:
 warning: no @param for value1Name
     public static void checkLessOrEqual(
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:171:
 warning: no @param for value2
     public static void checkLessOrEqual(
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:171:
 warning: no @param for value2Name
     public static void checkLessOrEqual(
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:183:
 warning: no @param for value
     public static void checkWithinRange(
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:183:
 warning: no @param for valueName
     public static void checkWithinRange(
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:183:
 warning: no @param for minValueInclusive
     public static void checkWithinRange(
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:183:
 warning: no @param for maxValueInclusive
     public static void checkWithinRange(
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:195:
 warning: no @param for value
     public static void checkWithinRange(
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:195:
 warning: no @param for valueName
     public static void checkWithinRange(
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:195:
 warning: no @param for minValueInclusive
     public static void checkWithinRange(
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/partial/Validate.java:195:
 warning: no @param for maxValueInclusive
     public static void checkWithinRange(
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/TDeserializer.java:85: 
warning: no @throws for org.apache.thrift.transport.TTransportException
     public TDeserializer(
            ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/TDeserializer.java:109:
 warning: no @throws for org.apache.thrift.transport.TTransportException
     public TDeserializer(
            ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TEndpointTransport.java:56:
 warning: no description for @param
      * @param newSize
        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TEndpointTransport.java:58:
 warning: no @throws for org.apache.thrift.transport.TTransportException
     protected void resetConsumedMessageSize(long newSize) throws 
TTransportException {
                    ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TEndpointTransport.java:78:
 warning: no description for @param
      * @param size
        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TEndpointTransport.java:90:
 warning: no description for @param
      * @param numBytes
        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TEndpointTransport.java:100:
 warning: no description for @param
      * @param numBytes
        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TEndpointTransport.java:102:
 warning: no @throws for org.apache.thrift.transport.TTransportException
     protected void countConsumedMessageBytes(long numBytes) throws 
TTransportException {
                    ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/AutoExpandingBufferWriteTransport.java:42:
 warning: no @throws for org.apache.thrift.transport.TTransportException
     public AutoExpandingBufferWriteTransport(
            ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TFileTransport.java:572:
 warning: no @param for args
     public static void main(String[] args) throws Exception {
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TFileTransport.java:572:
 warning: no @throws for java.lang.Exception
     public static void main(String[] args) throws Exception {
                        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TTransportFactory.java:35:
 warning: no @throws for org.apache.thrift.transport.TTransportException
     public TTransport getTransport(TTransport trans) throws 
TTransportException {
                       ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TIOStreamTransport.java:57:
 warning: no @throws for org.apache.thrift.transport.TTransportException
     protected TIOStreamTransport() throws TTransportException {
               ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TIOStreamTransport.java:76:
 warning: no @throws for org.apache.thrift.transport.TTransportException
     public TIOStreamTransport(InputStream is) throws TTransportException {
            ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TIOStreamTransport.java:122:
 warning: no @throws for org.apache.thrift.transport.TTransportException
     public TIOStreamTransport(InputStream is, OutputStream os) throws 
TTransportException {
            ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TIOStreamTransport.java:97:
 warning: no @throws for org.apache.thrift.transport.TTransportException
     public TIOStreamTransport(OutputStream os) throws TTransportException {
            ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TIOStreamTransport.java:49:
 warning: no @param for config
     protected TIOStreamTransport(TConfiguration config) throws 
TTransportException {
               ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TIOStreamTransport.java:49:
 warning: no @throws for org.apache.thrift.transport.TTransportException
     protected TIOStreamTransport(TConfiguration config) throws 
TTransportException {
               ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TIOStreamTransport.java:64:
 warning: no description for @param
      * @param config
        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TIOStreamTransport.java:67:
 warning: no @throws for org.apache.thrift.transport.TTransportException
     public TIOStreamTransport(TConfiguration config, InputStream is) throws 
TTransportException {
            ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TIOStreamTransport.java:105:
 warning: no description for @param
      * @param config
        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TIOStreamTransport.java:109:
 warning: no @throws for org.apache.thrift.transport.TTransportException
     public TIOStreamTransport(TConfiguration config, InputStream is, 
OutputStream os)
            ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TIOStreamTransport.java:84:
 warning: no description for @param
      * @param config
        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TIOStreamTransport.java:87:
 warning: no @throws for org.apache.thrift.transport.TTransportException
     public TIOStreamTransport(TConfiguration config, OutputStream os) throws 
TTransportException {
            ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TNonblockingServerSocket.java:56:
 warning: no @param for port
     public TNonblockingServerSocket(int port) throws TTransportException {
            ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TNonblockingServerSocket.java:56:
 warning: no @throws for org.apache.thrift.transport.TTransportException
     public TNonblockingServerSocket(int port) throws TTransportException {
            ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TNonblockingServerSocket.java:61:
 warning: no @param for port
     public TNonblockingServerSocket(int port, int clientTimeout) throws 
TTransportException {
            ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TNonblockingServerSocket.java:61:
 warning: no @param for clientTimeout
     public TNonblockingServerSocket(int port, int clientTimeout) throws 
TTransportException {
            ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TNonblockingServerSocket.java:61:
 warning: no @throws for org.apache.thrift.transport.TTransportException
     public TNonblockingServerSocket(int port, int clientTimeout) throws 
TTransportException {
            ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TNonblockingSocket.java:99:
 warning: no description for @param
      * @param selector
        ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TNonblockingSocket.java:121:
 warning: no @return
     public SocketChannel getSocketChannel() {
                          ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TNonblockingTransport.java:39:
 warning: no @return
     public abstract boolean startConnect() throws IOException;
                             ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TNonblockingTransport.java:39:
 warning: no @throws for java.io.IOException
     public abstract boolean startConnect() throws IOException;
                             ^
   
/opt/thrift/src/lib/java/src/main/java/org/apache/thrift/transport/TNonblockingTransport.java:46:
 warning: no @return
     public abstract boolean finishConnect() throws IOException;
                             ^
   100 warnings
   
   Deprecated Gradle features were used in this build, making it incompatible 
with Gradle 8.0.
   
   You can use '--warning-mode all' to show the individual deprecation warnings 
and determine if they come from your own scripts or plugins.
   
   See 
https://docs.gradle.org/7.4.2/userguide/command_line_interface.html#sec:command_line_warnings
   
   BUILD SUCCESSFUL in 1m 27s
   6 actionable tasks: 6 executed
   ```
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to