Jimexist commented on PR #2606: URL: https://github.com/apache/thrift/pull/2606#issuecomment-1125657932
> Looks good to me, for the most part. I would suggest a slight change to the error message. > > Also, there are some conditionals in the Gradle build files that check for Java 11. Those can be removed now. > > We'd also need to remove the CI checks that run using JDK 8, like that the Ubuntu Xenial builds, unless you want to restore your previous workaround to force JDK 11 to be installed. we don't need to update the xenial build, since using java toolchain means we are decoupling the JDK used to run gradle from the one used to compile Java. in the case of xenial, JDK8 is used to run gradle, which will download JDK 11 on its own before compiling Java. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
