Jimexist commented on code in PR #2607:
URL: https://github.com/apache/thrift/pull/2607#discussion_r873141475
##########
compiler/cpp/src/thrift/generate/t_java_generator.cc:
##########
@@ -485,11 +484,6 @@ string t_java_generator::java_package() {
return "";
}
-string t_java_generator::java_suppressions() {
- return "@SuppressWarnings({\"cast\", \"rawtypes\", \"serial\",
\"unchecked\", \"unused\"})"
- + endl;
-}
Review Comment:
> How certain are you that these aren't used? I'm pretty sure some of them
are still applicable in at least some situations.
yeah you are right - i tried to localize the warning suppression only to
find it's not worth it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
