ctubbsii commented on PR #2608:
URL: https://github.com/apache/thrift/pull/2608#issuecomment-1133751715

   > and proposition to move logging to one place
   
   I misunderstood this. I thought you were removing duplicate code and 
consolidating into a single method, but it didn't make sense, since this code 
is only called once.
   
   What you're actually doing is combining the exception handling logic, so 
it's all handled in one place. That makes sense to me now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to