nanreh commented on code in PR #2619:
URL: https://github.com/apache/thrift/pull/2619#discussion_r893720247
##########
lib/java/gradle/generateTestThrift.gradle:
##########
@@ -26,6 +26,8 @@ ext.genReuseSrc = file("$buildDir/gen-javareuse")
ext.genFullCamelSrc = file("$buildDir/gen-fullcamel")
ext.genOptionTypeJdk8Src = file("$buildDir/gen-option-type-jdk8")
ext.genUnsafeSrc = file("$buildDir/gen-unsafe")
+ext.genStructOrderTestASrc =
file("$buildDir/resources/test/struct-order-test/a")
+ext.genStructOrderTestBSrc =
file("$buildDir/resources/test/struct-order-test/b")
Review Comment:
Thanks for the feedback. Are you suggesting that instead of:
```
$buildDir/resources/test/struct-order-test/a/
$buildDir/resources/test/struct-order-test/b/
```
it could be improved as:
```
$buildDir/resources/test/struct-order-a/
$buildDir/resources/test/struct-order-b/
```
... or is there another change that would be preferable? thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
