simon0-o commented on PR #2469: URL: https://github.com/apache/thrift/pull/2469#issuecomment-1212896947
> The code is generally OK, minor issues aside. > > > We are adding a new `VALIDATION_FAILED` to `TApplicationException` > > This should be fine, I can't think of a realistic scenario where it'd be a problem. > > More generally, I'm not sure about "tool functions". It can easily cause further drift between supported languages. I think we should define and document which functions we support (`len()` is fine). We can add more in future versions if necessary. I add a supported functions table to the validator proposal, which can be modified when more functions or language supports are available. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
