yawaramin commented on PR #2652: URL: https://github.com/apache/thrift/pull/2652#issuecomment-1240173541
OK for the record existing tests are building and running with the following setup: Configure test build: ``` cd compiler/cpp/tests cmake -DCMAKE_PREFIX_PATH=/usr/local/opt/bison -DCMAKE_CXX_STANDARD=11 . ``` Build and run tests: ``` cmake --build . ctest ``` _But,_ the existing netstd/netcore tests seem to have a naming mixup which is preventing any tests from _actually_ running, which I checked by deliberately introducing an incorrect input into the `t_netcore_generator_functional_tests_helpers.cc` file and seeing that no tests failed. I will try to write a test for the OCaml and see if I can actually get it to fail first before trying to add test coverage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
