emmenlau commented on PR #2644:
URL: https://github.com/apache/thrift/pull/2644#issuecomment-1242656131
From a brief look, I think an inconsistency may have been there even before
your change. After your change, the line
`target_link_libraries(thrift_c_glib_zlib ${SYSLIBS})` is inconsistent with the
other statements of `target_link_libraries`, because some use the `PUBLIC`
keyword and others do not. Is that possibly the problem?
I think most of cmake uses the `PUBLIC` keyword nowadays in thrift, so maybe
add that where it's missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
