evetion commented on code in PR #2649: URL: https://github.com/apache/thrift/pull/2649#discussion_r967793917
########## lib/cpp/src/thrift/transport/TServerSocket.cpp: ########## @@ -70,7 +70,7 @@ // adds problematic macros like min() and max(). Try to work around: #define NOMINMAX #define WIN32_LEAN_AND_MEAN -#include <Windows.h> +#include <windows.h> Review Comment: It is portable, as Windows is case-insensitive (`windows.h`, `Windows.h` and even `WiNdOwS.h` are the same on Windows). However, when cross-compiling from a case-sensitive environment (most Linux), there's a difference and most tools use `windows.h`. In the same answer on Stackoverflow that you [linked](https://stackoverflow.com/a/15466951/7200132), it says: > Since windows.h will always work on both Windows and a Linux cross compile, I'd use #include <windows.h> if I ever thought about it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
