Jens-G commented on PR #2652:
URL: https://github.com/apache/thrift/pull/2652#issuecomment-1243034222

   > But, the existing netstd/netcore tests seem to have a naming mixup which 
is preventing any tests from actually running, which I checked by deliberately 
introducing an incorrect input into the 
t_netcore_generator_functional_tests_helpers.cc file and seeing that no tests 
failed.
   
   Was not really aware about this piece of code. Never looked into it. Since 
it was written for netcore it might be broken anyway, there are a number of 
differences between the two implementations. If anybody wants to fix any issues 
here, please do. I most certainly won't do it myself.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to