yawaramin commented on PR #2657: URL: https://github.com/apache/thrift/pull/2657#issuecomment-1243039996
Thanks for merging. After asking for advice on how to go about writing tests in the original PR, I did not receive a response so decided to try to come up with something myself. Most of the line count you're seeing here is from capturing snapshots of the generated OCaml code under various scenarios. I tried to keep the scenarios as simple as possible however the outputs of the service client implementations are verbose by their very nature. These snapshots will in the future help to prevent regressions if someone makes a mistaken change in the OCaml generator as I had done previously. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
