emmenlau commented on code in PR #2662:
URL: https://github.com/apache/thrift/pull/2662#discussion_r972714171


##########
debian/control:
##########
@@ -6,7 +6,7 @@ Build-Depends: dotnet-runtime-6.0, dotnet-sdk-6.0, debhelper 
(>= 9), build-essen
     pkg-config, libtool, bison, flex, libboost-dev | libboost1.56-dev | 
libboost1.63-all-dev,
     python-all, python-setuptools, python-all-dev, python-all-dbg,
     python3-all, python3-setuptools, python3-all-dev, python3-all-dbg,
-    openjdk-8-jdk | openjdk-8-jdk-headless | openjdk-11-jdk | 
openjdk-11-jdk-headless | default-jdk,
+    openjdk-8-jdk | openjdk-8-jdk-headless | openjdk-11-jdk | 
openjdk-11-jdk-headless | openjdk-17-jdk | openjdk-17-jdk-headless | 
default-jdk,

Review Comment:
   Do we even still need `openjdk-8-jdk` and `openjdk-8-jdk-headless`, or could 
they be dropped at the same time? Just asking, I'm not in the details!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to