Jimexist commented on PR #2690: URL: https://github.com/apache/thrift/pull/2690#issuecomment-1272551188
> It doesn't seem the travis issues are caused by this change (but I don't remember seeing the c++ and python test failures before 🤔) > > also a minor thing that can totally be done in another PR after this: currently since we support 2 go versions, we use xenial for the older version and bionic+focal for the newer version: > > * https://github.com/apache/thrift/blob/4f72788418d8ee331d8841310a4066fd0ba2e510/build/docker/ubuntu-xenial/Dockerfile#L139 > * https://github.com/apache/thrift/blob/4f72788418d8ee331d8841310a4066fd0ba2e510/build/docker/ubuntu-bionic/Dockerfile#L147 > * https://github.com/apache/thrift/blob/4f72788418d8ee331d8841310a4066fd0ba2e510/build/docker/ubuntu-focal/Dockerfile#L148 > > now with xenial going away, we would need to shift bionic (which would be the new oldest version we run on travis) to the older go version in order to still test both. hi @fishy how do you feel is that testing 1.18 is done in #2697 (as a follow up), then we don't need to update in here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
