kinoroy commented on code in PR #2708:
URL: https://github.com/apache/thrift/pull/2708#discussion_r995181504
##########
lib/go/thrift/type.go:
##########
@@ -38,9 +38,7 @@ const (
MAP = 13
SET = 14
LIST = 15
- UTF8 = 16
- UTF16 = 17
- //BINARY = 18 wrong and unusued
+ UUID = 16
Review Comment:
@fishy Crosstests until recently were only running Java/Kotlin so obviously
that was successful running crosstests against themselves even with incorrect
spec. Swift was recently added but was implemented to match Java so also has
UUID=17 so all those tests were passing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
